Angular-NgRx-GettingStarted icon indicating copy to clipboard operation
Angular-NgRx-GettingStarted copied to clipboard

Published 20 hours ago • verified publisher icon DeborahK

Minor bug on adding products when all removed - APM-0, APM-1, APM-2

Open dekideian opened this issue 4 years ago • 2 comments
trafficstars

Hello,

Really appreciate your work and your courses. Kudos! :)

Found a small bug, when all the products are removed, it is not possible to add a new one without explicitly mentioning an id. Have the fix on a separate branch ready for PR, cannot push it sadly, 403.

Best regards, Deian

dekideian avatar Aug 23 '21 13:08 dekideian

Opened a PR https://github.com/DeborahK/Angular-NgRx-GettingStarted/pull/52 :). Realized I can fork the repo and then I can push a branch and open a PR.

dekideian avatar Aug 23 '21 13:08 dekideian

Hi

You rock for taking the time to point this out!

I agree with you in a more real-world example you would guard for this. I would love to accept a PR to fix it and you are kind to offer but we strive to keep the code and the video in sync. For this reason, I do not think we should change it until the next course update. I have tagged this issue to address when we do the next update.

duncanhunter avatar Aug 23 '21 21:08 duncanhunter