deadbeef icon indicating copy to clipboard operation
deadbeef copied to clipboard

Page Up & Page Down in playlist seem to be hardcoded at 10 lines.

Open mdooligan opened this issue 8 years ago • 3 comments

They should be set dynamically to the number of visible tracks in the playlist viewport.

plugins/gtkui/dblistview.c around line 2100:

   else if (keyval == GDK_Page_Down) {
        if (cursor < ps->binding->count () - 1) {
            cursor += 10; // ps->rows = viewport.height/ps->rowheight;

Looking at the struct _DdbListview{} I guess you would need to get the viewport height and divide it by ps->rowheight to determine the appropriate number of lines?

Also the numpad KP_Home/KP_End/KP_Up/KP_Down/KP_Page_Up/KP_Page_Down keys should be bound to the non KP_ equivalents, IMHO. Maybe separate issue.

mdooligan avatar Apr 20 '16 08:04 mdooligan