ain icon indicating copy to clipboard operation
ain copied to clipboard

Account history and custom TX contain conflicting information

Open pawn-police opened this issue 3 years ago • 3 comments

What happened:

The account history entry and corresponding custom TX both specify a different "to token"

What you expected to happen:

I expected the "to token" to be the same in both the account history entry and corresponding custom TX.

How to reproduce it (as minimally and precisely as possible):

defi-cli getcustomtx 727460c2d402404eb90335b1bca3dcd94b8434634f8dfa79539370601752f1ed
{
  "type": "PoolSwap",
  "valid": true,
  "results": {
    "fromAddress": "dE4UnQhJFC1UmYgLaEDTYGpzsruqD55XyP",
    "fromToken": "2",
    "fromAmount": 0.00000644,
    "toAddress": "dVorVwqVYshUVMRLqPt6rWQBowZ1U5modL",
    "toToken": "2",
    "maxPrice": 0.00006779,
    "compositeDex": "BTC-DFI"
  },
  "blockhash": "0521fe666637aae30c11d215903a56320ff7172a965bcf7d6cbcc7276f5eaccb",
  "blockHeight": 1599588,
  "blockTime": 1644043031,
  "confirmations": 682869
}

defi-cli getaccounthistory dE4UnQhJFC1UmYgLaEDTYGpzsruqD55XyP 1599588 1
{
  "owner": "dE4UnQhJFC1UmYgLaEDTYGpzsruqD55XyP",
  "blockHeight": 1599588,
  "blockHash": "0521fe666637aae30c11d215903a56320ff7172a965bcf7d6cbcc7276f5eaccb",
  "blockTime": 1644043031,
  "type": "PoolSwap",
  "txn": 1,
  "txid": "727460c2d402404eb90335b1bca3dcd94b8434634f8dfa79539370601752f1ed",
  "amounts": [
    "-0.00000644@BTC"
  ]
}

defi-cli getaccounthistory dVorVwqVYshUVMRLqPt6rWQBowZ1U5modL 1599588 1
{
  "owner": "dVorVwqVYshUVMRLqPt6rWQBowZ1U5modL",
  "blockHeight": 1599588,
  "blockHash": "0521fe666637aae30c11d215903a56320ff7172a965bcf7d6cbcc7276f5eaccb",
  "blockTime": 1644043031,
  "type": "PoolSwap",
  "txn": 1,
  "txid": "727460c2d402404eb90335b1bca3dcd94b8434634f8dfa79539370601752f1ed",
  "amounts": [
    "0.09569930@DFI"
  ]
}

What are your environment parameters:

Full node 2.11.1 on Ubuntu

Anything else we need to know?:

All the instances I have found so far: all-transactions.txt

Some examples from the file:

  • https://defiscan.live/transactions/1383676f0a92aeed44f18d04bccd5b78df7c38aecf390c7ac802a45db38adea8
  • https://defiscan.live/transactions/233c81c890695b0873de507b232376bec377d557b3b126a7a896f441b007d9aa
  • https://defiscan.live/transactions/727460c2d402404eb90335b1bca3dcd94b8434634f8dfa79539370601752f1ed
  • https://defiscan.live/transactions/0865dfb2f8d42e6a83a9d094eeeec6a19bfd38c79773addc112a71ace5d1b131
  • https://defiscan.live/transactions/ab8aad9799870d750d714bc3dcad194bcd6fec67018200add7746b975876c055
  • https://defiscan.live/transactions/a32d15a99374ea513c4dcf69f88783a0a6b8f07e6f93792901f67667678be5fe
  • https://defiscan.live/transactions/aa46b66018f54643d1e53500bfe7405390d080c855063f9f2f70280283707260

pawn-police avatar Oct 01 '22 10:10 pawn-police

@pawn-police: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

defichain-bot avatar Oct 01 '22 10:10 defichain-bot

Hey, thanks for opening this issue. Were these transactions submitted using the defi-cli, the desktop/light wallet or some other wallet? Were you trying to swap from BTC to DFI, or were you trying a BTC to BTC transaction?

/triage accepted

shohamc1 avatar Oct 04 '22 08:10 shohamc1

The transactions were not submitted by me so I don't know how they have been submitted or what the intended outcome was.

Here is what I do know:

  • All of the transactions are rather old meaning I could not find any in recent blocks.
  • It does not only concern BTC to BTC swaps. In the all-transactions.txt that has been attached "token_to" comes from the custom TX and "token_to_alt" comes from the account history and you can see that there are several distinct mismatches.

pawn-police avatar Oct 04 '22 21:10 pawn-police