ain icon indicating copy to clipboard operation
ain copied to clipboard

FutureSwaps are not adding the destination token to the total balance of the loanToken

Open kuegi opened this issue 2 years ago • 3 comments

sorry for missing it in the review, but I think we missed adding the created tokens to the total balance of the loanToken.

Since they are minted, they should be tracked in the loantoken, right? the sources are "burned" but they stay within the smartcontract, so its fine to not remove them from the balance I think.

kuegi avatar Mar 30 '22 21:03 kuegi

@kuegi: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

defichain-bot avatar Mar 30 '22 21:03 defichain-bot

just verified on testnet: newly created dtoken from the swap are not reflected in the minted amount of gettoken call

kuegi avatar Mar 30 '22 21:03 kuegi

Thanks @kuegi - you are correct. This indeed needs to be fixed. A /live/economy/dfip2203_minted attr is missing.

prasannavl avatar Mar 31 '22 04:03 prasannavl