Remove `-dirty` flag from CI on release builds

[prasannavl]

The CI adds -dirty flags to release builds due to the git index being polluted during the build, which results in genbuild.sh adding dirty instead of suffix-less releases.

Thanks to further investigation by @Mixa84, inserting git diff-index at several points in the build to understand where:

WORKDIR /work

COPY --from=depends-builder /work/depends ./depends
COPY . .

RUN git diff-index HEAD --

RUN ./autogen.sh

results in:

2022-03-15T11:38:38.6388394Z :100644 000000 8a40c89365e395e1fccd294567e9f33c5b5a8126 0000000000000000000000000000000000000000 D	.github/CODEOWNERS
2022-03-15T11:38:38.6389147Z :100644 000000 30c16477569fa3375156df3ddef81766fc85b2ff 0000000000000000000000000000000000000000 D	.github/ISSUE_TEMPLATE/2-bug.md
2022-03-15T11:38:38.6389644Z :100644 000000 8d0d784789223147ab0e944b924e3c3f18536e43 0000000000000000000000000000000000000000 D	.github/ISSUE_TEMPLATE/3-feature.md
2022-03-15T11:38:38.6390006Z :100644 000000 35b68cfde615569cfeaa927482f7b6739f268d5e 0000000000000000000000000000000000000000 D	.github/ISSUE_TEMPLATE/config.yml
2022-03-15T11:38:38.6390353Z :100644 000000 cac04a982f3bedc4f93d02aafc4006ecd163a2e4 0000000000000000000000000000000000000000 D	.github/PULL_REQUEST_TEMPLATE.md
2022-03-15T11:38:38.6390703Z :100644 000000 ac56033391f335de03a877b9ff45bd118ee3daff 0000000000000000000000000000000000000000 D	.github/governance.yml
2022-03-15T11:38:38.6391016Z :100644 000000 64fd0ce86512162c346975e2f9d05a4031497f2b 0000000000000000000000000000000000000000 D	.github/labels.yml
2022-03-15T11:38:38.6391469Z :100644 000000 ed8ed462c4c13e4c2dec9ed5f6d5087f96cf3dd7 0000000000000000000000000000000000000000 D	.github/release-drafter.yml
2022-03-15T11:38:38.6391802Z :100644 000000 2646082e7ffdac51f02b7661457ea41e665c5197 0000000000000000000000000000000000000000 D	.github/stale.yml
2022-03-15T11:38:38.6392268Z :100644 000000 6f8bbb76af87a9805c66b9c4bd30b7c4b44cf7f8 0000000000000000000000000000000000000000 D	.github/workflows/dev-builds.yaml
2022-03-15T11:38:38.6392736Z :100644 000000 e5197680aeaab812c18adf1a010079537c488092 0000000000000000000000000000000000000000 D	.github/workflows/hotfix-builds.yaml
2022-03-15T11:38:38.6393234Z :100644 000000 6f96a6c64b88bdae83fd6c4b3ccebd8e3464f67e 0000000000000000000000000000000000000000 D	.github/workflows/jellyfish-tests.yml
2022-03-15T11:38:38.6393589Z :100644 000000 df5247af2fdd2186d14af8fdcda68a42e751f784 0000000000000000000000000000000000000000 D	.github/workflows/lint.yaml
2022-03-15T11:38:38.6394074Z :100644 000000 c4b30da564dc67c029022cab87b88ec8fa0aeaa2 0000000000000000000000000000000000000000 D	.github/workflows/oss-governance-bot.yml
2022-03-15T11:38:38.6394667Z :100644 000000 764b7fdd103076daf77e3fcc5a7e9840f77baf06 0000000000000000000000000000000000000000 D	.github/workflows/oss-governance-project-issue.yml
2022-03-15T11:38:38.6395585Z :100644 000000 ce04cdb39b4674cc60172433da04acc56c2b5115 0000000000000000000000000000000000000000 D	.github/workflows/oss-governance-project-pr.yml
2022-03-15T11:38:38.6396106Z :100644 000000 363595fb092a3ea8140775a17e3fb4c6fb9533fe 0000000000000000000000000000000000000000 D	.github/workflows/prune-artifacts.yaml
2022-03-15T11:38:38.6396600Z :100644 000000 869965bb5d65c8a99a30c1cf37e236eedafd7d16 0000000000000000000000000000000000000000 D	.github/workflows/release-builds.yaml
2022-03-15T11:38:38.6397079Z :100644 000000 471a2c2fbba5f3364e8876c8c2a8b0e64af6b405 0000000000000000000000000000000000000000 D	.github/workflows/release-drafter.yml
2022-03-15T11:38:38.6397561Z :100644 000000 36edcb4d566373b9f6842ccb2a15603e0cb657fe 0000000000000000000000000000000000000000 D	.github/workflows/sync-labels.yml
2022-03-15T11:38:38.6397896Z :100644 000000 3fdc63324b52fa8f8f726201925575f29cf5af5a 0000000000000000000000000000000000000000 D	.github/workflows/tests.yaml
2022-03-15T11:38:38.6398389Z :100644 000000 161bda04b7e5e7d0ec23f863ed302134d8a86640 0000000000000000000000000000000000000000 D	contrib/dockerfiles/arm-linux-gnueabihf.dockerfile
2022-03-15T11:38:38.6398951Z :100644 000000 7b7c27743c387f890aeaea2b9cb77894933dd40c 0000000000000000000000000000000000000000 D	contrib/dockerfiles/dockerhub/x86_64-pc-linux-gnu.dockerfile
2022-03-15T11:38:38.6399487Z :100644 000000 850e63b9d1821e829ab82d3c9888e19d7f3750ac 0000000000000000000000000000000000000000 D	contrib/dockerfiles/x86_64-apple-darwin18.dockerfile
2022-03-15T11:38:38.6400008Z :100644 000000 96c47db783f94543e3da1296e1d8f154835de9bc 0000000000000000000000000000000000000000 D	contrib/dockerfiles/x86_64-pc-linux-gnu-dev.dockerfile
2022-03-15T11:38:38.6400542Z :100644 000000 d5ac4475e978f0dd9040116fd0b68b000deecd5f 0000000000000000000000000000000000000000 D	contrib/dockerfiles/x86_64-pc-linux-gnu.dockerfile
2022-03-15T11:38:38.6401067Z :100644 000000 6133c4ebaedf50c0aa4410ce9636aaae269f460e 0000000000000000000000000000000000000000 D	contrib/dockerfiles/x86_64-w64-mingw32.dockerfile
2022-03-15T11:38:38.6401418Z :100644 000000 925c4465d7788eaa5ca5c9bbc05bb4a0ad2b3ad9 0000000000000000000000000000000000000000 D	src/univalue/gen/gen.cpp

This could likely be due dockerignore and gitignore being out of sync.

[defichain-bot]

@prasannavl: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

[prasannavl]

Everything else here is fine. But src/univalue/gen/gen.cpp should not have been there before the build in the first place. @Mixa84 - could you please investigate further?