Antonio Davide

Results 142 comments of Antonio Davide

> Good idea, not sure if I will find any practical usage for the ChangeReason enum, but the more well-defined public API there is the merrier. Implemented (I'm thinking to...

> But this may probably be the issue with separators themselves, drawn in the middle of empty characters instead of before or after them? I like separators drawn that way...

> Should metadata highlighting paint the whole part of column that it works with, or not touch the empty separator characters from the left and right sides? Like this? ![Screenshot_20220309_153303](https://user-images.githubusercontent.com/1503603/157462435-f1869aa9-0122-44c9-ae8d-2950788927a3.png)

Ok, I think that I have fixed everything. > In the screenshot the size of QByteArray is 23 bytes. If you try to highlight more than that, e. g. call...

> Hard to notice, but on the left side of header there is an area one pixel wide which remains unpainted, despite the usage of delegate. I can't reproduce with...

> The header is fine now, but there is still that small inconsistency with distance from border on the left and on the right. Look at the highlighted parts of...

> Could you introduce something like QHexDelegate::drawVerticalSeparators and QHexDelegate::drawHorizontalSeparator? I have found a way to draw the QFrame's VLine, but it required a few hacks. And also perhaps there should...

> Can support such display, no data does not show the number ![20220310204051](https://user-images.githubusercontent.com/22003930/157663924-2a4de9a6-b6d2-4ae2-a1d8-9eb664da5c45.png) I can add a byte mask, but you can't edit it from the hex part because they...

Yes, it looks fine on me too, pushed.

> More advanced features could include byte sequences with unknown data like `00 AB ?? ?? ?? CD EF`. If an unknown part is too long maybe the expression could...