postgres_ext-serializers icon indicating copy to clipboard operation
postgres_ext-serializers copied to clipboard

Support for active_model_serializers (>= 0.9.0)

Open rsespinosa opened this issue 9 years ago • 7 comments

Is there any chance you can add active_model_serializers (>= 0.9.0) support any time soon? Being able to use "grape-active_model_serializers" combined with "postgres_ext-serializers" would be a major win for any rails api. Thanks and regards,

rsespinosa avatar Sep 23 '16 07:09 rsespinosa

AMS 0.9 support shouldn't be to hard to add, but AMS 1.0 uses the JSON API serialization format and would likely require a backwards incompatible rewrite of most of the code.

felixbuenemann avatar Sep 23 '16 17:09 felixbuenemann

I believe AMS 0.9 support would be great, as grape-active_model_serializers has many stable versions compatible with it. As a matter of fact, AMS 0.9 is currently the stable version, and even AMS 0.10.0 includes breaking changes for previous versions code (it's not backward compatible with 0.9.x nor 0.8.x).

rsespinosa avatar Sep 23 '16 18:09 rsespinosa

@rsespinosa Would you like to work on a PR to add 0.9 compatibility? I've had a look at this about two weeks ago but ran out of time, so I could push my WIP branch. I've implemented most of the changes required in interfacing with the new version without breaking backwards compatibility, but there's likely still a some hours work required to get the tests to pass.

felixbuenemann avatar Oct 05 '16 20:10 felixbuenemann

Hi @felixbuenemann , I'm sorry for the late reply. I've been pretty complicated myself. Sounds like a good idea. If you could please push your WIP regarding this, probably me or a member of the team can start working on this in little time. Thanks and regards,

rsespinosa avatar Oct 25 '16 20:10 rsespinosa

I pushed my sprint as a WIP commit to this branch:

https://github.com/felixbuenemann/postgres_ext-serializers/tree/wip/ams-0.9-support

felixbuenemann avatar Oct 25 '16 22:10 felixbuenemann

@felixbuenemann @rsespinosa I was wondering if you guys are still working on AMS 0.9x support?

oyeanuj avatar Feb 04 '17 02:02 oyeanuj

@oyeanuj I'm not actively working on it, feel free to work on the WIP branch.

felixbuenemann avatar Feb 06 '17 09:02 felixbuenemann