Davis Vaughan
Davis Vaughan
Probably `vec_locate_min()` but yea i dont like the python style argmin naming scheme
I was under the impression that we'd have to do this renaming no matter what because `vec_unchop()` has the wrong prefix, but generally we want something that is symmetric with...
@lionel- do you want to do a review of this since we decided to push forward with this name change?
One other thing that quickly came up (but hasn't been discussed much) is: ```r name_repair = list("unique", quiet = TRUE) ``` This gives a way to set `quiet` right in...
That's fine by me, I don't feel strongly about the options-list
This feels a little unexpected to me, I think I like how `list_flatten()` currently works. Not erroring on scalar elements seems useful to me. ```r purrr::flatten(list(1, 2:3)) #> [[1]] #>...
> also accepted by base::print(), but undocumented. `max` is actually documented in `?print.default`, if that is what you were referring to
Generally this looks good, but I think that I have a fairly strong aversion to the list part of this interface. From slider, I learned that there is a meaningful...
Yea definitely
This is probably the right first step, but we will rebuild it from scratch when we tackle https://github.com/r-lib/vctrs/issues/1063 for real