Davis Vaughan

Results 580 comments of Davis Vaughan

I've run into this a lot. It has something to do with `months()` being a base R S3 function and the way lubridate overloads it to become an S4 function...

Works with clock's month grouping ``` r library(clock) x [1] "1958-01-01 UTC" ```

As many people here have seen, `strptime()` lacks the capability to correctly _parse_ the ISO 8601 week based format, although `strftime()` can _format_ it. This is in the docs for...

Also works with clock ``` r library(clock) date_ceiling(date_time_build(1970, 1, 1, zone = "UTC"), precision = "day") #> [1] "1970-01-01 UTC" ```

In clock, flooring with daily and sub-daily precisions works as the OP expected (I believe). It uses a default origin of 1970-01-01 in the time zone of the input and...

> But I don't know if any existing tidyverse function uses similar syntax. FWIW this is basically how `fct_recode()` works (name represents new level, value was the old level), so...

I think there are two problems here. ``` r library(tibbletime) library(dplyr) data(FB) FB_time # A time tibble: 6 x 8 #> # Index: date #> symbol date open high low...

For the first problem of _changing the name of the index_, I think that every function that could run into this problem calls `get_index_quo()` at some point. I think it...

Additionally, I am going to support `rename()` as a dplyr verb. This means that if the user does `date2=date` like above, the resulting object is no longer a tbl_time, but...

The only way to possibly detect it is if it came from a `dplyr::rename()`. Trying to capture a manual rename from a user would be pretty hard I think, and...