MessageLoggerV2-fixed icon indicating copy to clipboard operation
MessageLoggerV2-fixed copied to clipboard

Notifications whitelist fix

Open Voleno1 opened this issue 2 years ago • 8 comments

Didn't work, tried fixing with 0 experience in js, pulled it off

Voleno1 avatar Mar 20 '23 23:03 Voleno1

A lot of duplicated code, consider converting it into a reusable local function?

XspeedPL avatar Mar 21 '23 14:03 XspeedPL

Thanks for the PR. Can you tell the difference in behavior? I don't quite understand the need of checking it again here...

Sorry if code is trashy, I didn't really know what I was doing, never coded in JS, just tried my best to fix notification whitelisting along other features, just added more checks for whitelisting and guild & channel selection, there may be checks that are used already, because i just copied and pasted them there.

Voleno1 avatar Mar 21 '23 17:03 Voleno1

Didn't work, tried fixing with 0 experience in js, pulled it off

Huh? It works for me...

Davilarek avatar Mar 30 '23 08:03 Davilarek

Didn't work, tried fixing with 0 experience in js, pulled it off

https://user-images.githubusercontent.com/63198192/229280038-cf85bfcf-5ba5-41bd-9af6-2897fdcb9bb2.mp4

Huh? It works for me...

heres a video of hopefully showing what i mean whitelisting doesn't work at all clicking blacklist shows server in whitelist, moving does nothing

Voleno1 avatar Apr 01 '23 10:04 Voleno1

huh, weird. I'll look into that.

Davilarek avatar Apr 01 '23 13:04 Davilarek

since 2.5.5 has been released, check if it works now @Voleno1

Davilarek avatar Apr 16 '23 11:04 Davilarek

since 2.5.5 has been released, check if it works now @Voleno1

ever since that fix i don't get the notifications method like that at the top right, the only way v2logger will notify me now is by disabling xenolib notifications and using default toast option which is better than nothing but i vastly prefer the former like in the video above and other plugins utilize this as well ie AppNotifications and FriendNotifications plugins etc just not working for messagelogerv2 plugin for some reason now

iDeparture avatar Apr 19 '23 04:04 iDeparture

This doesn't happen for me, try resetting your MLv2 config (DONT FORGET TO BACKUP), also can someone else confirm this? Just to make sure this isn't a configuration issue

Davilarek avatar Apr 22 '23 16:04 Davilarek