Floresta icon indicating copy to clipboard operation
Floresta copied to clipboard

Development Debts

Open jaoleal opened this issue 7 months ago • 3 comments

After #176 i was alarmed by some development debt, which include:

  • Grammatical doc errors(discovered by typos.)
  • Incompatible Versions, such as
    • found crate miniscript compiled by an incompatible version of rustc
    • error: cannot determine resolution for the macro json
    • cannot find attribute serde in this scope all that captured by nightly clippy that ran by pre-commit and i wonder if that can be considered a bug since nightly is required for running fmt...

A proper fix to it is changing Actions(which enforce the use of nightly) and Pre-commit(Used so we do not have a surprise while being checked by Actions when pushing) to share the same version and behavior.

Dealing with nigthly directly is rough since is too unstable(Change every day), should we consider the use of beta for fmt ? If nightly fmt is really required Ill mention the way that rust-bitcoin deal with it by reading their /.github files and scripts.

jaoleal avatar Jul 03 '24 19:07 jaoleal