codice-fiscale icon indicating copy to clipboard operation
codice-fiscale copied to clipboard
verified publisher icon DavidePastore

fix warnings

Open garak opened this issue 1 year ago • 2 comments

Fix #76

garak avatar Jul 26 '24 08:07 garak

Hi @garak. Could you please also include some tests for it?

DavidePastore avatar Jul 26 '24 08:07 DavidePastore

I just added a test case (and cleaned up tests a bit). I realized it was my fault in the end, so the case is the same as the other issue I mentioned in mine. The current test is passing without warnings. If you run the same test on master, you'll get the warnings instead.

The problem, at this point, is that the calculator calculates an invalid cf when passing a shorter belfiore code. The problem is present in master branch too. Let met know if you prefer to merge this PR and wait for a different PR fixing this other problem, or if it's better to fix everything here

garak avatar Jul 26 '24 10:07 garak

Thanks for your PR, @garak. Let's have this fix in another PR.

DavidePastore avatar Feb 10 '25 09:02 DavidePastore