David Zbarsky
David Zbarsky
Ack, I am moving this week and will be mostly offline, but I'll give it a shot next week!
@oquenchil I had a chance to give it a quick spin - on my repro, it takes the sandbox creation times from 7s to 200ms, this is amazing! Unfortunately I...
Yes, it was the master branch of that repo, and it's the same build command I posted earlier. I wonder if my self-built bazel is weird somehow, - I've never...
It was on macos
Here's the first error I saw: ``` touch: bazel-out/darwin_arm64-fastbuild/bin/out_37: Operation not permitted ERROR: /Users/david.zbarsky/nodejs-repro/BUILD.bazel:61:12: Executing genrule //:gen_out_43 failed: (Exit 1): bash failed: error executing Genrule command (from target //:gen_out_43) /bin/bash...
``` --- Bisect Result first bad commit is https://github.com/bazelbuild/bazel/commit/3fddc7f38ace43981d839ed4558b8a457caf41fb ``` cc @fmeum
Yep, that commit fixes it, and the one before it (`eebf5f97e33fa4abad128c029e5d254783d805ca`) is broken. I think we should be all good now, and looking forward to getting these patches in!
@oquenchil Could you rebase your PR on top of main (or at least the commit @fmeum linked)? Then I'll be be able to test it out. I tried to rebase...
@alexeagle I think there's additional glue needed to plug esbuild into `ts_project` but it's doable 100% in "userspace" so it's fine to close this out, though its maybe worth having...
Yeah, I have the macro bit Jason mentioned done now, I'll polish it a bit and submit