InkPageIndicator icon indicating copy to clipboard operation
InkPageIndicator copied to clipboard

Issue on pre-lollipop

Open ZacSweers opened this issue 9 years ago • 6 comments

There's an animation bug with this on pre-lollipop where the dot to the right side disappears during the transition.

See: http://webmshare.com/dLEEL

I think it's due to the change to addPath, which I don't think it a like-for-like equivelant to Path.Op.UNION.

ZacSweers avatar Dec 21 '15 06:12 ZacSweers

Whoops hit enter to soon, editing

ZacSweers avatar Dec 21 '15 06:12 ZacSweers

@hzsweers Is this bug still persisting? I can't reproduce it.

DavidPacioianu avatar Feb 12 '16 16:02 DavidPacioianu

Yes. Try any API 16 device

ZacSweers avatar Feb 23 '16 08:02 ZacSweers

I'm facing this problem, but all the dots disappear suddenly. Sometimes they show, sometimes they don't, only the selected one gets shown. Also on API 16. I'll try to find the issue.

leonardo2204 avatar Jun 15 '16 19:06 leonardo2204

Another issue, when pager count reached 10+, the option's animation becoming very slow and jerky. I think it's due to the change path.op to path.addPath, So I changed the code as:

if(Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) { combinedUnselectedPath.op(getUnselectedPath(page, dotCenterX[page], dotCenterX[nextXIndex], page == pageCount - 1 ? INVALID_FRACTION : joiningFractions[page], dotRevealFractions[page]), Path.Op.UNION); }else { combinedUnselectedPath.addPath(getUnselectedPath(page, dotCenterX[page], dotCenterX[nextXIndex], page == pageCount - 1 ? INVALID_FRACTION : joiningFractions[page], dotRevealFractions[page])); }

matrixxun avatar Jul 04 '16 02:07 matrixxun

@matrixxun Please make a pull request with your change.

DavidPacioianu avatar Nov 13 '16 10:11 DavidPacioianu