DavidKorczynski

Results 274 comments of DavidKorczynski

This is a bit of a guess from my side, in that I'm not entirely sure on what is needed to make this complete. The current state is I can...

am happy to integrated the corpus minimization (looks straightforward https://github.com/google/honggfuzz/blob/master/docs/USAGE.md#corpus-minimization--m) -- do you know at this point if there will be anything more missing once that's done?

Added a PoC for corpus minimisation, the logs show: ``` 2022-07-25 14:48:40,387 - run_bot - INFO - Running merge... 2022-07-25 14:48:40,387 - run_bot - INFO - Minimizing honggfuzz corpus -...

Lint should work now, locally I get: ``` Running: pylint src/clusterfuzz/_internal/bot/fuzzers/honggfuzz/engine.py | | -------------------------------------------------------------------- | Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) | Running: yapf -d...

thanks for the reviews @jonathanmetzman @oliverchang -- all should be addressed!

> One last request: could we add some integration test to https://github.com/google/clusterfuzz/blob/e9ff4b99f82cfdba0d370a06db5c882af9a94313/src/clusterfuzz/_internal/tests/core/bot/fuzzers/honggfuzz/honggfuzz_engine_test.py to help us make sure this doesn't break in the future? Yes! Added a crashing test case following...

> > Note you need to set `INTEGRATION=1` to actually run integration tests. Ah, thanks. The CI is probably failing because of the integration test then. Is it possible to...

> Are you able to reproduce this locally? I was able to reproduce. Am not entirely sure what the underlying issue was but it may be due to an old...

It's simple an added service - it can help catch regressions early or catch fuzzing breaks early. It was only recently released officially and there are already many projects on...

> it only runs on PR's We can set it to run on Push too. But, in the event you still don't find it useful then let's just close this...