pods-frontier icon indicating copy to clipboard operation
pods-frontier copied to clipboard

Merge Frontier Views into the existing Pods Template component

Open sc0ttkclark opened this issue 11 years ago • 8 comments
trafficstars

Let's merge what we've got for Frontier Views (based on your Mini-frontier work you showed me today / yesterdayish) into our core Pods Template component. Here's a task list to help you keep track of what needs to happen. We'll eventually be decoupling all of the components in Pods core itself, and at that point, Pods Templates may find it's way back into Frontier, but for now, let's avoid two separate templating engines/terminologies.

Pods Template Component

  • [x] Add Auto-complete and custom codemirror to Content box, you'll likely want to override our content handler completely here (bonus points if you do the same content codemirror minus auto-complete for Pod Pages!)
  • [x] Add a Pod select metabox, which refreshes the Reference info and auto-complete data
  • [x] Add Reference metabox, which lists available magic tags etc
  • [ ] Add "Pod" column to the post list table for the _pods_template post type
  • [x] Frontier loop handling support in Pods Template handler, would be interested to see what changes are needed here

Pods Frontier

When Pods Frontier is activated, Frontier should add the following to the core Pods Template editor:

  • [ ] Add Advanced metabox with tabbed info for Item ID, Parameters, Advanced options, and possibly moving the "Restriction" metabox into it (not a biggie if you want to save time, don't do Restriction)
  • [ ] Add "Embed" column to the post list table for the _pods_template post type, show the Shortcode and PHP function needed for embedding -- use template names instead of IDs if possible here, only show the embed info if the template has a "Pod" selected

sc0ttkclark avatar Dec 13 '13 07:12 sc0ttkclark

Implement changes into the Pods 2.x branch, maybe do a pull request for now as a fork or as a separate branch based on 2.x, up to you, we'll likely release Pods 2.3.19 or a smaller set of features in Pods 2.4 than what's slated for Pods 3.0

sc0ttkclark avatar Dec 13 '13 07:12 sc0ttkclark

I'm on it! I'll do a new branch 2.x-frontier ok with that?

DavidCramer avatar Dec 13 '13 17:12 DavidCramer

Sure, sounds good!

sc0ttkclark avatar Dec 13 '13 17:12 sc0ttkclark

pushed first update to 2.x-frontier branch. I updated codemirror and added my custom plugin for the autocomplete. Modified it a little by adding in the loadpod reference to the autocomplete plugin directly. so now {@ brings up the "no pod loaded" option and selecting it brings up a load reference pod select box. This means it doesn't save the the actual pod reference, it simply loads it for autocomplete.

It's the first run so some small issues- will work more on it tomorrow.

DavidCramer avatar Dec 14 '13 19:12 DavidCramer

Oh, and pressing Ctrl+P brings up the load pod reference panel to switch pod.

DavidCramer avatar Dec 14 '13 19:12 DavidCramer

Created a plugin to do the overrides for now committed to branch 1.x-template-editor. On the point of "Frontier loop handling support in Pods Template handler, would be interested to see what changes are needed here" No changes where needed. All work is done in the 'pods_templates_pre_template' and 'pods_templates_do_template' filters and some tricky magic.

DavidCramer avatar Jan 18 '14 18:01 DavidCramer

Just to revisit this, I'm wondering if we might want to remove the Template component from Pods core entirely in 3.0 and move it all into Frontier? Remembering that plugins will be installable via the components admin in 3.0, which I promise to finish next week.

We could have a "classic mode" that will be the old functionality only. Might make sense to merge Pods Frontier and Pods Frontier Auto Template at that point as well.

@sc0ttkclark What do you think about this?

Shelob9 avatar Jun 21 '14 20:06 Shelob9

The long term goal is for the components to live entirely on their own as plugins. The Templating component was going to get merged into Frontier at some point, so it won't become it's own plugin like the rest, it'll get absorbed.

I don't know that 3.0 is a good time for this, but I think we should have Frontier include it's own template code, so when Frontier is activated, there is no "Template" component needed, it's just "on".

sc0ttkclark avatar Jun 21 '14 22:06 sc0ttkclark