[bug] Bitrate selection menu pops up without any keyboard shortcut

[k939kk]

[bug] Inspite of set_max_bitrate set to true the bitrate selection menu keeps popping up on any new instance of netflix.

Also, it is a bit unclear what the override and reset buttons functions are in the bitrate selection menu. A small note in the readme would be useful.

Browser: Firefox 124.0.1

[DavidBuchanan314]

setting set_max_bitrate to true is what makes it pop up, set it to false if you want to invoke it manually

[DavidBuchanan314]

(the menu is supposed to disappear once the max bitrate has been selected, but it's buggy)

[borsigu]

is it possible to automatically pick the highest bitrate rather than picking from the pop-up every episode?

[DavidBuchanan314]

That's what set_max_bitrate is supposed to do, that's the option

[onli]

I found the reason, at least on my system.

set_max_bitrate() returns false when one of the selects is disabled. But the audio select is disabled for me. Thus I changed that abort:

https://github.com/DavidBuchanan314/Turbo-Recadmiumator/blob/50dff66f61a08b95c3206e2766ad4ed8e9bfe706/src/cadmium-playercore-shim.js#L129

to:

if (select.disabled){
	if (list == AUDIO_SELECT) {
		continue
	} else {
		return false;
	}
}

That wasn't enough though, because this check also failed:

https://github.com/DavidBuchanan314/Turbo-Recadmiumator/blob/50dff66f61a08b95c3206e2766ad4ed8e9bfe706/src/cadmium-playercore-shim.js#L139

I'm not sure what the intention was here? So I removed that if.

Now it works for me.

PS: Even with set_max_bitrate set to false the player patching works in enabling 1080p playback on Linux, if available. Not sure why, just by adding the profile maybe? But I also stumbled over a movie where all of this had no effect, I guess where netflix really does not deliver 1080p playback. Or maybe there are additional playback profiles though ought to be enabled there?

[DavidBuchanan314]

PS: Even with set_max_bitrate set to false the player patching works in enabling 1080p playback on Linux, if available. Not sure why, just by adding the profile maybe? But I also stumbled over a movie where all of this had no effect, I guess where netflix really does not deliver 1080p playback. Or maybe there are additional playback profiles though ought to be enabled there?

I don't know for sure, but I believe certain content is configured to require "VMP" (Verified Media Path), which sadly is not available on the Linux platform.

[onli]

That might be it.

Well, I hope the described code changes help with the max bitrate issue at least :)