esp32-owb icon indicating copy to clipboard operation
esp32-owb copied to clipboard

Using in Arduino Espressif32 framework

Open ttlappalainen opened this issue 1 year ago • 1 comments

I have been using your library successfully several months - maybe over year in Espressif32 framework. Most I have been using Espressif32 version 3.5, but now I am going to 6.1. You could have mention that it works also on that framework.

Some succestions:

  • Could ESP_LOGE be ESP_LOGD instead? I do not see why e.g., "rx_items == 0" would be an error. It is normal that 1-wire line can be empty.
  • In library.json you could have "frameworks": ["espidf","arduino"],
  • There is not much changed from version 3 -> 5 or 6. Could there be conditional compiling to keep same source still for older version? e.g.,
    #if ESP_IDF_VERSION_MAJOR>3
    rmt_set_gpio(info->rx_channel, RMT_MODE_RX, gpio_num,false);
    rmt_set_gpio(info->tx_channel, RMT_MODE_TX, gpio_num,false);
    #else
    rmt_set_pin(info->rx_channel, RMT_MODE_RX, gpio_num);
    rmt_set_pin(info->tx_channel, RMT_MODE_TX, gpio_num);
    #endif

I can also make PR, if you agree my improvements.

ttlappalainen avatar Mar 31 '23 06:03 ttlappalainen