paper-datatable icon indicating copy to clipboard operation
paper-datatable copied to clipboard

Issues on Sarafi

Open AnasSahel opened this issue 9 years ago • 10 comments

Hello, The element is not working on Sarafi (Mac OSX El Capitain). Even the web site where docs and demos are held does not show up on Sarafi

Regards

AnasSahel avatar Feb 02 '16 16:02 AnasSahel

It's not stated anywhere, but the code base reveals the use of arrow functions which is not supported in fx Safari or any IE browser, and Chrome before version 45 :( Pretty fresh approach.

Anyhow if you transpile your code through babel (maybe in your build system) you should be fine.

noahlaux avatar Feb 09 '16 20:02 noahlaux

I ran the code through Babel, and I can confirm this fixes the issue.

Maybe it would be a nice idea to add a build system to paper-datatable? This way ES6 code will not present a problem and we could use other helpful stuff like sass.

Juravenator avatar Feb 19 '16 10:02 Juravenator

I can do that but the author seems not accept any pr

RoXuS avatar Feb 19 '16 10:02 RoXuS

I currently have a fork that does just this. It compiles sass and uses Babel to convert ES6 code.

I once made a pull request that converted ES6 to ES5 without using a build tool (and thus basically abandoning developing with ES6). There the author has expressed his view on developing with older code. https://github.com/David-Mulder/paper-datatable/pull/49

However with a build system things are quite different. One could keep developing with the newest technologies and you get compatibility with older browsers for free.

Could the author maybe revisit this issue?

Juravenator avatar Feb 19 '16 10:02 Juravenator

+1

pieter-vincken-agilians avatar Feb 19 '16 10:02 pieter-vincken-agilians

+1

Protoss78 avatar Feb 23 '16 08:02 Protoss78

+1

marxtseng avatar Mar 07 '16 09:03 marxtseng

+1

allenmoatallen avatar Mar 09 '16 17:03 allenmoatallen

I had the same issue. Just to add a detail, the result is the paper-datatable-card does not insert the columns inside its paper-material but directly in place of its content tag.

EDIT The element should be turned into a bundle. It shouldn't be the user of the library to transpile all dependencies. How to not break the internet with this one weird trick.

masonlouchart avatar Mar 31 '16 14:03 masonlouchart

Massive props to @Juravenator for his fork that transpiles this down to ES5. I realised this doesn't support Safari less than 4 hours before a project was about to drop, and approx. 50% of our audience is on iOS.

aendra-rininsland avatar Apr 09 '16 19:04 aendra-rininsland