Add optional logging destination for integration with Crashlytics

[msanders]

See #68. Only catch is this currently needs to be dragged into the parent project since we don't have access to the symbols for Crashlytics at time time we're linking the library (not sure if there's a better workaround).

[msanders]

@DaveWoodCom thoughts?

[DaveWoodCom]

I still like the idea, it's just low in priorities right now. Ideally anyone can use this already, without it being added to the master branch. But I'll need to set up a Crashlytics account etc to fully test. Priority for me right now is still getting out my next game (so close), and then cramming on the Apple TV to hit the day 1 release date!

[esetnik]

+1 it's working well for me

[dusek]

I too am using it nicely, though I needed to add:

import Crashlytics

to the beginning, which would in consequence make XCGLogger depend on Crashlytics too (requiring a change in .podspec), which is unnecessary for those who do not use Crashlytics with XCGLogger (unless XCGLogger's philosophy is "batteries included" :smile:)

So perhaps this should be in the podspec made as a separate "module" (if podspec allows that, I don't know) so that people having 'XCGLogger' in their Podfile would not get 'Crashlytics' unless explicitly opting in for XCGCrashlyticsLogDestination (which could be specified in their Podfile as e.g. XCGLogger/Crashlytics)?

Or another option is to make a separate repo from this, with its own podspec.

[karlbecker]

Just a note that the only reason we are still on CocoaLumberjack is because it sends data up to Crashlytics.

CocoaLumberjack isn't so hot with Swift, though, so XCGLogger seems like a great one to move to... but we'd really like a slick, supported interface to Crashlytics.

Any chance of this getting resurrected?

[esetnik]

@karlbecker you can use this version. It works just fine for me.

//
//  XCGLogger+Crashlytics.swift
//  XCGLogger
//
//  Created by Michael Sanders on 8/12/15.
//  Copyright 2015 Cerebral Gardens. All rights reserved.
//
import XCGLogger
import Crashlytics

// MARK: - XCGCrashlyticsLogDestination
// - An optional log destination that sends the logs to Crashlytics
open class CrashlyticsLogDestination: BaseDestination {
  public override init(owner: XCGLogger?, identifier: String) {
    super.init(owner: owner, identifier: identifier)
    showDate = false
  }

  open override func output(logDetails: LogDetails, message: String) {
    let args: [CVarArg] = [message]
    withVaList(args) { (argp: CVaListPointer) -> Void in
      CLSLogv("%@", argp)
    }
  }
}

[karlbecker]

It says this branch has conflicts that must be resolved - will I be losing out on lots of nice improvements that have been made since this branch was created?

Any chance @dusek 's suggestion could happen?

So perhaps this should be in the podspec made as a separate "module" (if podspec allows that, I don't know) so that people having 'XCGLogger' in their Podfile would not get 'Crashlytics' unless explicitly opting in for XCGCrashlyticsLogDestination (which could be specified in their Podfile as e.g. XCGLogger/Crashlytics)?

[esetnik]

@karlbecker you don't need to use this branch you can just drop the extension I pasted above into your application and add a CrashlyticsLogDestination and you're good to go. That version I pasted above works with the latest official release of XCGLogger. It's just an extension for Crashlytics.

[karlbecker]

Oh fantastic! Thanks for the explanation - I'm still fairly new to Swift!

[ArkadiGiniApps]

You should update the code to handle logging via the optional queue like this:

` import Crashlytics import XCGLogger

open class CrashlyticsLogDestination : BaseQueuedDestination {

// MARK: - Overridden Methods
/// Print the log to the Apple System Log facility (using NSLog).
///
/// - Parameters:
///     - message:   Formatted/processed message ready for output.
///
/// - Returns:  Nothing
///
open override func write(message: String) {
    
    let outputClosure = {
        let aTextArray : [CVarArg] = [message]
        CLSLogv("%@", getVaList(aTextArray))
    }
    
    if let logQueue = logQueue {
        logQueue.async(execute: outputClosure)
    } else {
        outputClosure()
    }
}

}`

[fassko]

I wanted to note that Crashlytics will be gone. Users have to move to Firebase. I'm not sure how that will affect this PR. They haven't released new SDK yet.