php-language-extensions icon indicating copy to clipboard operation
php-language-extensions copied to clipboard

Improve CI

Open szepeviktor opened this issue 2 years ago • 5 comments

@DaveLiddament This is my default CI.

kép

Problems.

  1. There are no unit tests. As far as I see it is not possible to write unit tests.
  2. Other tools don't need multiple PHP versions.

Separate jobs and steps allow contributors to see where errors occur.

What are your thoughts?

szepeviktor avatar Jan 05 '23 21:01 szepeviktor

Thanks for this.

There are a few bits I'd like from this.

  • .gitattributes (I really should be adding this to all my projects).
  • The editorconfig is not something I've seen before, looks useful. Thanks for showing it to me. We should use this too.

I'm not sure about the increased complexity of the CI process. Given CI is so quick, both locally and on GH I don't see the value of making it more complex for this project.

DaveLiddament avatar Jan 06 '23 16:01 DaveLiddament

.gitattributes (I really should be adding this to all my projects).

It controls exported files.

The editorconfig is not something I've seen before, looks useful. Thanks for showing it to me. We should use this too.

It controls all characters of the project.

I'm not sure about the increased complexity of the CI process

Making every check a step in CI makes the UI very easy to read.

kép

szepeviktor avatar Jan 06 '23 17:01 szepeviktor

Reducing my default CI now ... 🏃🏻‍♂️

szepeviktor avatar Jan 06 '23 17:01 szepeviktor

Done 🍏

kép

szepeviktor avatar Jan 06 '23 17:01 szepeviktor

As a follower of this repo: I appreciate the work but don't find that the enumeration of CI results in the UI adds anything. Maybe if it helps contributors...

MGatner avatar Jan 06 '24 11:01 MGatner