bt-ccxt-store icon indicating copy to clipboard operation
bt-ccxt-store copied to clipboard

Multi exchange broker mappings

Open sandroboehme opened this issue 5 years ago • 2 comments

As promised, this is the PR for #7 "Enhance the broker mappings and store them for multiple exchanges". But it's a bigger one. There one thing I'm not sure about: As I extend the Binance specific broker from CCXTBroker I wanted to avoid that it registers with the CCXTStore as well which is why I've prevented that with if name == 'CCXTBroker': like this:

class MetaCCXTBroker(BrokerBase.__class__):
    def __init__(cls, name, bases, dct):
        '''Class has already been created ... register'''
        # Initialize the class
        super(MetaCCXTBroker, cls).__init__(name, bases, dct)
        if name == 'CCXTBroker':
            CCXTStore.BrokerCls = cls

sandroboehme avatar Mar 08 '19 23:03 sandroboehme

@sandroboehme Amazing stuff... Will try to review after I look at the feeds

Dave-Vallance avatar Mar 11 '19 00:03 Dave-Vallance

@Dave-Vallance Any chance for this pull request to be merged into the master?

armezit avatar Aug 06 '21 09:08 armezit