mach-nix icon indicating copy to clipboard operation
mach-nix copied to clipboard

Update nixpkgs and add setuptools dependency to distlib

Open Atry opened this issue 2 years ago • 3 comments

This PR tried to upgrade nixpkgs to https://github.com/NixOS/nixpkgs/commit/d6d83488a774a789a902c3b4f462faa922acf106, which is the parent commit of https://github.com/NixOS/nixpkgs/commit/3e3c94bc4afbfb23b1a4f7e72452d751bb8d2115.

This PR did not upgrade nixpkgs to https://github.com/NixOS/nixpkgs/commit/3e3c94bc4afbfb23b1a4f7e72452d751bb8d2115 or a later revision, because https://github.com/NixOS/nixpkgs/commit/3e3c94bc4afbfb23b1a4f7e72452d751bb8d2115 upgraded packaging, introducing the breaking changes in https://github.com/pypa/packaging/issues/530.

I also tried to upgrade nixpkgs to a newer revision in https://github.com/DavHau/mach-nix/pull/547, which includes fixes to errors due to https://github.com/pypa/packaging/issues/530.

Atry avatar Mar 28 '23 06:03 Atry

I added setuptools to distlib in order to fix error ModuleNotFoundError: No module named 'setuptools', however, it seems the test stuck because of the fix:

https://github.com/DavHau/mach-nix/actions/runs/4539990576/jobs/8000410559?pr=548

@DavHau , do you have any idea about it?

Atry avatar Mar 28 '23 15:03 Atry

Timed out after 6h. Strange. I'll just run it again. Let's see

DavHau avatar Mar 28 '23 19:03 DavHau

I think the timeout is due to upgrading nixpkgs, not because of adding setuptools. I split the setuptools part of this PR into #551, which passes CI.

Atry avatar Apr 12 '23 23:04 Atry