DavHau

Results 328 comments of DavHau

> @DavHau eslint has a cyclic dep with eslint-utils, and es-abstract has 3 packages like that. Just installing these in an empty dir is sufficient to test. > > But...

The problem with the script receiving the electron binary hashes is fixed by now. The hashes need to be added to this file: https://github.com/nix-community/dream2nix/blob/main/overrides/nodejs/default.nix#L180

Currently you need to fork dream2nix and update the hash entries in https://github.com/nix-community/dream2nix/blob/0131c22c369f8c4c661aea7a395e94669a7f5974/overrides/nodejs/default.nix#L180 We should add a better way to override these hashes though. Also we should add a script...

Yes, I think at least a package of the same major version must exist in nixpkgs, otherwise it won't work. We could improve that of course.

No, it means it would produce the error you posted above and not build anything. You probably just have to update the nixpkgs input of the dream2nix flake

Did you do any performance benchmarks to see how the performance compares against the existing implementation? Some newer pure translators use the `simpleTranslate2` helper instead of `simpleTranslate`. The latter should...

There now seems to be an infinite recursion in the haskell example for some reason. BTW, you can run all tests locally via `nix run .#tests-all`. Or just the examples...

> I can let the builder call it directly, but it doesn't make sense to me that the algo is wrong. I'm not saying it is wrong, but your algorithm...

> and the prettier build is failing because [it has a `build` script](https://github.com/prettier/prettier/blob/00ec91bfdee2e9bc592e4d1cf842507e50a86bbb/package.json#L165), which I think is non-standard but the builder executes it because it's the main package. Plus I...

I have played with this a while, and completely forgot to respond here. I'm sorry for that. From my observation, the problem seems to be that jest excludes directories that...