dart_pdf icon indicating copy to clipboard operation
dart_pdf copied to clipboard

Chore: replace WebView with WKWebView

Open sgsm74 opened this issue 1 year ago • 4 comments

'WebView' was deprecated in macOS 10.14: No longer supported

sgsm74 avatar Aug 12 '23 07:08 sgsm74

Codecov Report

Patch and project coverage have no change.

Comparison is base (90ad768) 36.25% compared to head (5931883) 36.25%. Report is 2 commits behind head on master.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1457   +/-   ##
=======================================
  Coverage   36.25%   36.25%           
=======================================
  Files         140      140           
  Lines       21644    21644           
=======================================
  Hits         7848     7848           
  Misses      13796    13796           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 12 '23 14:08 codecov-commenter

It seems that's not enough.

DavBfr avatar Aug 12 '23 14:08 DavBfr

I have a branch with WKWebView but it's incompatible with macOS < 11.0

DavBfr avatar Aug 12 '23 14:08 DavBfr

https://github.com/DavBfr/dart_pdf/commit/d19639f39579ee3c4367926b19ad63a79a97ec9d

DavBfr avatar Aug 12 '23 14:08 DavBfr