polar icon indicating copy to clipboard operation
polar copied to clipboard

Fix initiallyOpen not working in prod mode

Open dopenguin opened this issue 1 year ago • 1 comments

Summary

The fix of #123 was not working in production mode. By adding a new state parameter to @polar/core, this issue is now resolved.
While I was at it, I also moved the logic of the watcher to the store to have it in line with other plugins.

Instructions for local reproduction and review

  • npm run meldemichel:dev
  • npm run meldemichel:build && npm run meldemichel:build:serve

dopenguin avatar Apr 19 '24 19:04 dopenguin

🏓 @dopenguin

🏓 @warm-coolguy

dopenguin avatar May 06 '24 16:05 dopenguin

🏓 @dopenguin

🏓 @warm-coolguy

🏓 @dopenguin

warm-coolguy avatar May 29 '24 10:05 warm-coolguy

🏓 @dopenguin

🏓 @warm-coolguy

🏓 @dopenguin

🏓 @warm-coolguy

dopenguin avatar May 31 '24 16:05 dopenguin