database_cleaner-active_record icon indicating copy to clipboard operation
database_cleaner-active_record copied to clipboard

[FIX] Typo for deletion strategy

Open maniSHarma7575 opened this issue 1 year ago • 4 comments

Motivation / Background

Closes: #95

For deletion strategy there is a typo in the clean method. Instead of tables_to_truncate changed it to tables_to_clean which is more meaningful in case of deletion strategy.

To maintain consistency and inheritance change the name in the truncation as well from tables_to_truncate to tables_to_clean.

maniSHarma7575 avatar Jan 16 '24 08:01 maniSHarma7575

@etagwerker Can you please check this?

maniSHarma7575 avatar Jan 16 '24 08:01 maniSHarma7575

Closing this as tables_to_truncate is calling super class method. But still the name is confusing.

Naming convention is not up to the mark.

maniSHarma7575 avatar Jan 16 '24 09:01 maniSHarma7575

I am opening this PR. I made changes in both truncation and deletion, transitioning from 'tables_to_truncate' to 'tables_to_clean.'

maniSHarma7575 avatar Jan 17 '24 07:01 maniSHarma7575

@etagwerker Please review.

maniSHarma7575 avatar Jan 20 '24 03:01 maniSHarma7575