database_cleaner-active_record
database_cleaner-active_record copied to clipboard
Support Rails 7.2+
The schema_migration
method was moved in https://github.com/rails/rails/pull/51162
Red tests are due to https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/93
@casperisfine would Rails ever consider a public API for accessing this model or table name?
would Rails ever consider a public API for accessing this model or table name?
Hum, I dunno. I was quite happy I was able to move those without breaking the public API. But I guess we could expose them on AR::Base
and commit to that. But I wouldn't take this decision alone, at the very least @eileencodes would need to agree.
would Rails ever consider a public API for accessing this model or table name?
I'd be fine with schema_migration
being public but not the class. When I removed the inheritance on Base it also removed the ability to do most queries, so it only responds to some methods. I don't want PRs making that class (or InternalMetadata) more robust.
Not necessarily a breaking change for 7.2 but it would be great if #102 could also get included with this.
@ghiculescu Looks good, thank you!