mlops-zoomcamp icon indicating copy to clipboard operation
mlops-zoomcamp copied to clipboard

Readability and best practices | Type hinting for add_features in module 3 code

Open Odessit007 opened this issue 1 year ago • 1 comments

It seems to be a better practice to use generic type hints in such cases (it looks nicer and doesn't get notifications from some IDEs like PyCharm)

Odessit007 avatar Jun 11 '23 14:06 Odessit007

This is a good PR, but I don't think it's a good idea to accept it - if I do, the code in the repo and in the videos will be different, and will be confusing for the students

alexeygrigorev avatar Jun 12 '23 13:06 alexeygrigorev

That's a good point. Closing it.

Odessit007 avatar Jun 23 '23 21:06 Odessit007