machine-learning-zoomcamp icon indicating copy to clipboard operation
machine-learning-zoomcamp copied to clipboard

Published 20 hours ago • verified publisher icon DataTalksClub

notes correction in 06 Decision Trees...

Open lucapug opened this issue 3 years ago • 1 comments

Inside 02-data-prep.md , in the train/val/test split bullet note at the moment is : "Split the data with the distribution of 80% train, 20% validation, and 20% test sets with random seed to 11"

should be:

Split the data with the distribution of 60% train, 20% validation, and 20% test sets with random seed to 11

lucapug avatar Oct 13 '22 09:10 lucapug

can you please open a PR? thank you

alexeygrigorev avatar Oct 13 '22 13:10 alexeygrigorev

Hi @lucapug I wanted to create the Pull Request but couldn't find the cited passage.

  • https://github.com/alexeygrigorev/mlbookcamp-code/search?q=Split+the+data+with+the+distribution+of+80%25+train%2C+20%25+validation%2C+and+20%25+test+sets+with+random+seed+to+11
  • https://github.com/alexeygrigorev/mlbookcamp-code/search?q=02-data-prep.md

@lucapug where did you find this text passage?

bsenst avatar Nov 06 '22 14:11 bsenst

I can read it here: https://github.com/alexeygrigorev/mlbookcamp-code/blob/master/course-zoomcamp/06-trees/02-data-prep.md

it is at the 6th bullet point.

lucapug avatar Nov 06 '22 14:11 lucapug

I can read it here: https://github.com/alexeygrigorev/mlbookcamp-code/blob/master/course-zoomcamp/06-trees/02-data-prep.md

it is at the 6th bullet point.

@lucapug thanks for the hint. pull request has been created. have a nice weekend 😃

bsenst avatar Nov 06 '22 15:11 bsenst