data-engineering-zoomcamp icon indicating copy to clipboard operation
data-engineering-zoomcamp copied to clipboard

Improved docker-compose file for data ingestion

Open Mathanraj-Sharma opened this issue 2 years ago • 1 comments

  • Adding dependencies for services to execute them in order
  • Adding health checks to verify services started properly
  • Adding network configuration to connect to existing custom docker network with user configurations

Mathanraj-Sharma avatar Jan 19 '24 10:01 Mathanraj-Sharma

@alexeygrigorev please review and merge it, if it is useful

Mathanraj-Sharma avatar Jan 19 '24 10:01 Mathanraj-Sharma

This is a very useful PR but I'm afraid I can't accept it - this will be misleading for many students (like "why is this file different from the videos?")

An alternative could be creating a new docker compose file, describing it somewhere and then linking this post to this repo. The post could be an md file in your personal repo, for example

alexeygrigorev avatar Jan 29 '24 18:01 alexeygrigorev