course-management-platform icon indicating copy to clipboard operation
course-management-platform copied to clipboard

Style: enhance the style of some platform pages

Open mostafanasser2000 opened this issue 1 year ago • 6 comments

Style: enhance the style of some platform pages

Title: CSS enhancements to improve the platform UI.

Description

In this pull request, I try to use ChatGPT to implement several CSS enhancements to improve the platform's UI.

Changes Made

  • enhance the page layout and make pages responsive
  • create a better login page with social icons
  • change how courses are displayed on the website
  • replace links to the github repo and official site of data talks with icons
  • improve homework form

Visual Changes

https://github.com/user-attachments/assets/045340b7-7aa6-450e-9008-c2d7bc9f6efa

mostafanasser2000 avatar Jul 25 '24 19:07 mostafanasser2000

looks great! can you please ask chatgpt to merge it with the existing styles? and if you can use the existing style classes, it'd be great, so it's easier to track what was changed

alexeygrigorev avatar Jul 31 '24 05:07 alexeygrigorev

I don't think there will be a problem merging it as styles are added inside the <style> tag in the <head> not inside the CSS file which will not cause using collectstatic command, and the other style classes are bootstrap classes using bootstrap4.5.2 which are used before, so there will no conflict between classes

mostafanasser2000 avatar Aug 01 '24 21:08 mostafanasser2000

here is what the last commit introduce

  • move all CSS from template to CSS files
  • add a default image for the course card so there is no need to use a website that creates placeholder images anymore

the final preview of the website

https://github.com/user-attachments/assets/b24b5080-19f6-4fad-b928-cc4294c41756

mostafanasser2000 avatar Aug 06 '24 21:08 mostafanasser2000

I definitely like it but not everything, and because the change is too large it's too difficult for me to accept it all at once. Is there a way to gradually change it?

alexeygrigorev avatar Aug 21 '24 21:08 alexeygrigorev

Let's maybe start with a PR for the login page?

alexeygrigorev avatar Aug 21 '24 21:08 alexeygrigorev

ok I will close this pull request retrieve all changes back and create a new one for the login page only, I think focusing on Django related PR's will be helpful at this time

mostafanasser2000 avatar Aug 21 '24 22:08 mostafanasser2000

We have a new page for social logins. I'll close this for now but feel free to reopen for smaller changes

alexeygrigorev avatar Sep 29 '25 17:09 alexeygrigorev