course-management-platform icon indicating copy to clipboard operation
course-management-platform copied to clipboard

Fix Clear UI with correct answers

Open mostafanasser2000 opened this issue 9 months ago • 10 comments

  • fixes #11

case when the user answers a question incorrectly

before

before

after

after

case when the users don't answer a question

Screenshot from 2024-05-04 23-58-28

@alexeygrigorev

mostafanasser2000 avatar May 04 '24 21:05 mostafanasser2000

How does it work?

I'll add a bit more context to the original issue

alexeygrigorev avatar May 13 '24 12:05 alexeygrigorev

I think this is not right behavior because it doesn't show the correct answer in Q2, and the original problem is still there - the correct answer is selected in the last picture

alexeygrigorev avatar May 13 '24 12:05 alexeygrigorev

Perhaps we could just add a line saying "no answer was submitted"? or something like that

alexeygrigorev avatar May 13 '24 12:05 alexeygrigorev

what I understand from the context you just added is that if a student submits homework and there is a question he doesn't submit we display the correct answer as well as a "no answer was submitted" label and if he chooses the wrong answer for a question we display the correct answer as well as the wrong answer like the old behavior.

here is what I think you want

scenario1: student not answer a question

scenario3

scenario2: student does not submit a homework

scenario1

mostafanasser2000 avatar May 13 '24 13:05 mostafanasser2000

Looks great! I think for both scenarios it could be the same UI - i.e. the yellow thing with "no answer was submitted" is okay for scenario 2, I think. What do you think?

alexeygrigorev avatar May 14 '24 12:05 alexeygrigorev

I think it will be ok to add it as well to homework that the student has not submitted, and what if we change the label from "No answer was submitted" to "Question not answered" for clarity

mostafanasser2000 avatar May 14 '24 13:05 mostafanasser2000

final version

scenario1: student not answer a question

Screenshot from 2024-05-15 14-32-21

scenario2: student does not submit a homework

Screenshot from 2024-05-15 14-29-55

mostafanasser2000 avatar May 15 '24 11:05 mostafanasser2000

looks great! can you please update the code? will be happy to accept it

alexeygrigorev avatar May 15 '24 19:05 alexeygrigorev

okay just checked - it looks like the code is updated. is it the final version?

alexeygrigorev avatar May 15 '24 19:05 alexeygrigorev

I think adding some tests will not hurt. Do they pass now?

alexeygrigorev avatar May 15 '24 19:05 alexeygrigorev