Buttons icon indicating copy to clipboard operation
Buttons copied to clipboard

put CDN files to repo

Open maruilian11 opened this issue 9 years ago • 9 comments

Hi, I'm from cdnjs. Recently we want to add your lib to https://cdnjs.com. Could you please consider adding buttons.dataTables.min.css and dataTables.buttons.min.js to repo? like jquery.dataTables.min.css and jquery.dataTables.min.js So that we can use our git auto-update config to get files from every git tag. Thank you very much!

https://github.com/cdnjs/cdnjs/issues/10005

maruilian11 avatar Dec 18 '16 19:12 maruilian11

Hi,

Thanks for your message. Create to hear you want to include this software on cdnjs.

There is another thread in another one of my repos about this: https://github.com/DataTables/FixedHeader/issues/83 . If you have any questions about my replies there I'd be happy to answer them.

DataTables avatar Dec 19 '16 11:12 DataTables

@DataTables Thank you for your quick reply. I think we can use this repo to set up our auto-update config. https://github.com/DataTables/Dist-DataTables-Buttons/tree/master/js

But there are only js files, I saw you provide buttons.dataTables.min.css on your site. Is there other repo providing the css file? Or is it possible also put buttons.dataTables.min.css to DataTables/Dist-DataTables-Buttons? Thank you!

maruilian11 avatar Dec 19 '16 17:12 maruilian11

Hi,

The buttons.dataTables.min.css file is in Dist-DataTables-Buttons-DataTables.

The "core" distribution repo contains only the base Javascript. Then you use one of the styling repos (-DataTables, -Bootstrap, etc) to including the styling.

The reason for that was npm. It didn't really provide a way to conditionally select only certain files depending on the style selected.

DataTables avatar Dec 20 '16 10:12 DataTables

@DataTables Our auto-update config doesn't support the multiple repo function. Do you mind if we may need to add these files as two libs?

maruilian11 avatar Dec 23 '16 08:12 maruilian11

Do you mind if we may need to add these files as two libs?

I'm afraid I don't really understand what that means?

However, I do see how this multiple repo setup can be a bit of a pain for you! I will look into providing the minified files in this repo in the new year.

DataTables avatar Dec 23 '16 10:12 DataTables

@DataTables thank you, let will help us a lot! If you decide not to provide the files, just tag us, we will handle this problem ourself.

Merry Christmas and Happy New Year :)

maruilian11 avatar Dec 23 '16 17:12 maruilian11

@DataTables did you put files in the repo? CDNjs still missing datatable buttons. Would be good if somebody from CDNjs finally put library in their CDN

kant2002 avatar Aug 14 '18 23:08 kant2002

The files to use on the CDN are in this repo. There are a number of styling repos such as the DataTables one and Bootstrap4 one which should also be used.

DataTables avatar Aug 15 '18 07:08 DataTables

@DataTables so I assume that I should ping somebody from CDNjs team, so they do what needed on their side. Is this correct?

kant2002 avatar Aug 15 '18 08:08 kant2002

This is a really old issue now - I never followed up at the time - sorry! Buttons can be found on CDNJS here: https://cdnjs.com/libraries/datatables.net-buttons .

AllanJard avatar Jun 02 '23 10:06 AllanJard