sem-prov-ontologies icon indicating copy to clipboard operation
sem-prov-ontologies copied to clipboard

Address some notes on the salmon ontology

Open amoeba opened this issue 4 years ago • 2 comments

While doing another scan of the salmon ontology (as checked into git), I'm noticing some things that seemed odd which we might look at.

  • Under "Total recruit abundance", we've broken out freshwater/saltwater ages in such a way that the freshwater age is the parent class of the total age.

    Screen Shot 2021-09-15 at 8 39 44 PM

    The parent classes with just freshwater age don't have definitions yet but maybe the label should be updated to say it's for al 0-ocean fish, not "age class 0" which sounds odd.

  • Recruits per spawner is a subclass of "Recruit abundance" which I guess isn't wrong but it'd fit more naturally as a subclass of "Salmon productivity". I also notice we don't have any terms about productivity.

amoeba avatar Sep 16 '21 04:09 amoeba

This is an area I haven't yet reviewed, and need to do so

mpsaloha avatar Sep 16 '21 16:09 mpsaloha

Thanks @mpsaloha, I'll be curious to hear your thoughts!

amoeba avatar Sep 16 '21 18:09 amoeba