dinky icon indicating copy to clipboard operation
dinky copied to clipboard

[Fix-4514][metadata] Adding type to DriverPool's key

Open jrnie opened this issue 4 weeks ago • 3 comments

  • Adding type to DriverPool's key

Purpose of the pull request

Fix-4514: [Bug] [metadata] DriverPool key needs to include a type to distinguish the JDBC connector types.

Brief change log

  • Add type to org.dinky.metadata.driver.Driver.java#build
  • Add type to org.dinky.controller.DataSourceController.java#saveOrUpdateDataBase

Verify this pull request

This pull request is code cleanup without any test coverage.

jrnie avatar Dec 01 '25 12:12 jrnie

The data source name is unique.

aiwenmo avatar Dec 08 '25 11:12 aiwenmo

image image cdc任务首次进入时name并非独特的,比如图中的jdbc

The data source name is unique.

jrnie avatar Dec 08 '25 12:12 jrnie

It is possible to ensure uniqueness when constructing the "name", or objects with the same physical connection can be reused.

aiwenmo avatar Dec 09 '25 01:12 aiwenmo

https://github.com/DataLinkDC/dinky/pull/4523

aiwenmo avatar Dec 18 '25 09:12 aiwenmo