dinky icon indicating copy to clipboard operation
dinky copied to clipboard

[Bug] [dinky-admin] The flinksql multi-version switch button does not take effect

Open dsanww opened this issue 10 months ago • 5 comments

Search before asking

  • [x] I had searched in the issues and found no similar issues.

What happened

When I add any configuration items in flinksql, and when I click on a version of toggle, the sql content does not change, and an exception is thrown: Caused by: cn.hutool.core.convert.ConvertException: Unsupported source type: class java.lang.String at cn.hutool.core.convert.impl.BeanConverter.convertInternal(BeanConverter.java:98) ~[hutool-all-5.8.31.jar:5.8.31] at cn.hutool.core.convert.AbstractConverter.convert(AbstractConverter.java:58) ~[hutool-all-5.8.31.jar:5.8.31] at cn.hutool.core.convert.ConverterRegistry.convert(ConverterRegistry.java:243) ~[hutool-all-5.8.31.jar:5.8.31] at cn.hutool.core.convert.ConverterRegistry.convert(ConverterRegistry.java:262) ~[hutool-all-5.8.31.jar:5.8.31] at cn.hutool.core.convert.Convert.convertWithCheck(Convert.java:753) ~[hutool-all-5.8.31.jar:5.8.31] at cn.hutool.core.bean.copier.CopyOptions.lambda$new$0(CopyOptions.java:96) ~[hutool-all-5.8.31.jar:5.8.31] at cn.hutool.core.bean.copier.CopyOptions.convertField(CopyOptions.java:373) ~[hutool-all-5.8.31.jar:5.8.31] at cn.hutool.core.bean.copier.BeanToBeanCopier.lambda$copy$0(BeanToBeanCopier.java:84) ~[hutool-all-5.8.31.jar:5.8.31] at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684) ~[?:1.8.0_191] at cn.hutool.core.bean.copier.BeanToBeanCopier.copy(BeanToBeanCopier.java:51) ~[hutool-all-5.8.31.jar:5.8.31] at cn.hutool.core.bean.copier.BeanCopier.copy(BeanCopier.java:92) ~[hutool-all-5.8.31.jar:5.8.31] at cn.hutool.core.bean.BeanUtil.copyProperties(BeanUtil.java:795) ~[hutool-all-5.8.31.jar:5.8.31] at cn.hutool.core.bean.BeanUtil.copyProperties(BeanUtil.java:769) ~[hutool-all-5.8.31.jar:5.8.31] at org.dinky.service.impl.TaskServiceImpl.rollbackTask(TaskServiceImpl.java:779) ~[dinky-admin-1.2.0.jar:?] at org.dinky.service.impl.TaskServiceImpl$$FastClassBySpringCGLIB$$22087f7c.invoke() ~[dinky-admin-1.2.0.jar:?] at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218) ~[spring-core-5.3.31.jar:5.3.31] at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:792) ~[spring-aop-5.3.31.jar:5.3.31] at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163) ~[spring-aop-5.3.31.jar:5.3.31] at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:762) ~[spring-aop-5.3.31.jar:5.3.31] at org.springframework.aop.aspectj.MethodInvocationProceedingJoinPoint.proceed(MethodInvocationProceedingJoinPoint.java:89) ~[spring-aop-5.3.31.jar:5.3.31] at org.dinky.aop.UdfClassLoaderAspect.round(UdfClassLoaderAspect.java:55) ~[dinky-admin-1.2.0.jar:?] ... 122 more

Image

Image

What you expected to happen

no error

How to reproduce

add any configuration items in flinksql job,and switch to this version

Anything else

No response

Version

dev

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

dsanww avatar Feb 20 '25 02:02 dsanww

无法复现

Zzm0809 avatar Feb 20 '25 03:02 Zzm0809

Try refreshing the page the correct sql can be gotten. But configuration can not roll back, it is indeed a bug. It is caused by the type difference of field configJson between Task.class and TaskVersion.class.

MactavishCui avatar Feb 20 '25 03:02 MactavishCui

Try refreshing the page the correct sql can be gotten. But configuration can not roll back, it is indeed a bug. It is caused by the type difference of field configJson between Task.class and TaskVersion.class.

If it is a task with configuration items (other configuration items), as I have shown in the figure above, then this version of the task will not be rolled back, neither the sql content nor the configuration, and there will be no successful message returned

dsanww avatar Feb 20 '25 03:02 dsanww

Try refreshing the page the correct sql can be gotten. But configuration can not roll back, it is indeed a bug. It is caused by the type difference of field configJson between Task.class 和 TaskVersion.class.

If it is a task with configuration items (other configuration items), as I have shown in the figure above, then this version of the task will not be rolled back, neither the sql content nor the configuration, 和 there will be no successful message returned

1.状态更新问题, 回滚成功后没有获取最新的 sql 内容, 导致没有更新编辑器内的值 -> 修复 PR: #4230 2.更新时对配置字段的处理可能存在问题 3.前端缓存状态数据未更新

Zzm0809 avatar Feb 20 '25 05:02 Zzm0809

Hello @, this issue has not been active for more than 30 days. This issue will be closed in 7 days if there is no response. If you have any questions, you can comment and reply.

你好 @, 这个 issue 30 天内没有活跃,7 天后将关闭,如需回复,可以评论回复。

github-actions[bot] avatar Apr 01 '25 00:04 github-actions[bot]