dinky icon indicating copy to clipboard operation
dinky copied to clipboard

[Bug] [OssResourceManager] The root path of the OSS configuration must not start with "/", which conflicts with the configuration of the History Server.

Open jiangwwwei opened this issue 1 year ago • 1 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

What happened

image

Dinky's OssResourceManager relies on the aws-sdk implementation, and when constructing requests using its API, the file path is the Object Name, which should not start with a "/" (the aws SDK will automatically add a "/" at the beginning of the object name when building the HTTP request). If the root path in Dinky's Oss configuration starts with "/", it will cause an error indicating an invalid object name. image

However, the HistoryServer's request to oss is implemented by flink-s3-fs-presto, and it requests the direct path. If a "/" is not added at the beginning, it will report an error stating that it is not an absolute path.

What you expected to happen

Both the resource manager and the history server can access OSS normally.

How to reproduce

  1. Use OSS Resource
  2. In the root path configuration, add and do not add "/"
  3. Observe the file upload/download status of the Resource and the operation of the History Server.

Anything else

It is worth mentioning: In OssResourceManager, the "/" before the path in getFullDirectoryStructure() is specifically handled and removed, but other methods do not have this treatment. image

Version

1.2.0

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

jiangwwwei avatar Dec 24 '24 06:12 jiangwwwei

Hello @, this issue has not been active for more than 30 days. This issue will be closed in 7 days if there is no response. If you have any questions, you can comment and reply.

你好 @, 这个 issue 30 天内没有活跃,7 天后将关闭,如需回复,可以评论回复。

github-actions[bot] avatar Mar 01 '25 00:03 github-actions[bot]