system-tests
system-tests copied to clipboard
chore(sampling): add manual keep parametric system test
trafficstars
Motivation
We've been having issues regarding sampling decisions in our services. Some services wants to manual keep a trace and the Go tracer currently cannot manual keep a trace if the upstream decision was to drop it.
This system test ensure that we have a consistent way of handling manual keep over distributed traces.
5 tracers need a fix, a JIRA card has been created for follow-up
Changes
New parametric system test for manual keep
Workflow
- ⚠️ Create your PR as draft ⚠️
- Work on you PR until the CI passes
- Mark it as ready for review
- Test logic is modified? -> Get a review from RFC owner.
- Framework is modified, or non obvious usage of it -> get a review from R&P team
:rocket: Once your PR is reviewed and the CI green, you can merge it!
Reviewer checklist
- [ ] If PR title starts with
[<language>], double-check that only<language>is impacted by the change - [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
- [ ] A docker base image is modified?
- [ ] the relevant
build-XXX-imagelabel is present
- [ ] the relevant
- [ ] A scenario is added (or removed)?
- [ ] Get a review from R&P team