system-tests
system-tests copied to clipboard
[Debugger] Fix log snapshot tests
trafficstars
Motivation
The Node.js tracer would fail if the test probe didn't look like a real probe.
Changes
Ensure that the probe sent to the tracer contains a capture object, when captureSnapshot is set to true. This was introduced recently: #5576
This makes the test probe look more like a real probe, since a tracer might expect this object to be present (the Node.js tracer expects this).
If we want to have a system test to validate that tracers can handle the situation where this object isn't present, that should be a dedicated test for that scenario.
Workflow
- ⚠️ Create your PR as draft ⚠️
- Work on you PR until the CI passes
- Mark it as ready for review
- Test logic is modified? -> Get a review from RFC owner.
- Framework is modified, or non obvious usage of it -> get a review from R&P team
:rocket: Once your PR is reviewed and the CI green, you can merge it!
Reviewer checklist
- [ ] If PR title starts with
[<language>], double-check that only<language>is impacted by the change - [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
- [ ] A docker base image is modified?
- [ ] the relevant
build-XXX-imagelabel is present
- [ ] the relevant
- [ ] A scenario is added (or removed)?
- [ ] Get a review from R&P team