system-tests icon indicating copy to clipboard operation
system-tests copied to clipboard

Stricter dynamic configuration tests

Open watson opened this issue 2 months ago • 1 comments

Motivation

The current tests only verifies that a configuration telemetry event is received, but not that it's the expected one. This has lead to errors in some of the tracers, in which the tracer sends up an incorrect telemetry event, which was never caught by the system tests.

Changes

Add an extra assertion every place we expect a specific telemetry event.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • [ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • [ ] A docker base image is modified?
    • [ ] the relevant build-XXX-image label is present
  • [ ] A scenario is added (or removed)?

watson avatar Sep 18 '25 14:09 watson