system-tests icon indicating copy to clipboard operation
system-tests copied to clipboard

process-discovery: Fix test for nodejs

Open vitkyrka opened this issue 3 months ago • 0 comments
trafficstars

Motivation

Discovered while trying to test https://github.com/DataDog/dd-trace-js/pull/6228

Changes

The assumption that pid 1 is the traced process doesn't hold, fix it.

Note that currently the nodejs test is (1) still marked as missing feature and (2) still fails due to a bug in the tracer implementation (will be fixed in an upcoming release).

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • [ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • [ ] A docker base image is modified?
    • [ ] the relevant build-XXX-image label is present
  • [ ] A scenario is added (or removed)?

vitkyrka avatar Aug 07 '25 15:08 vitkyrka