system-tests
system-tests copied to clipboard
Add debugger system tests for rate limiting and probes on the same location
trafficstars
Motivation
In this PR we add two new tests to the DEBUGGER_METHOD_PROBES_SNAPSHOT scenario:
- one test for rate limiting that calls the same endpoint 10 times in a row and asserts that we only capture one snapshot (the rate limiting for snapshot capture should be 1/s).
- one test for multiple probes on the same location, where we assert that both probes generate a snapshot.
Disclaimer: these are the first system tests I've written, they were made during a system tests workshop with my team in NYC.
Changes
Add two new tests.
Workflow
- ⚠️ Create your PR as draft ⚠️
- Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
- Mark it as ready for review
- Test logic is modified? -> Get a review from RFC owner. We're working on refining the
codeownersfile quickly. - Framework is modified, or non obvious usage of it -> get a review from R&P team
- Test logic is modified? -> Get a review from RFC owner. We're working on refining the
:rocket: Once your PR is reviewed, you can merge it!
Reviewer checklist
- N/A If PR title starts with
[<language>], double-check that only<language>is impacted by the change - [x] No system-tests internal is modified. Otherwise, I have the approval from R&P team
- [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
- N/A A docker base image is modified?
- N/A A scenario is added (or removed)?