system-tests
system-tests copied to clipboard
Pass additional env vars to docker mode container
Motivation
New AWS env vars were not passed properly in Docker mode.
Changes
- Add AWS env vars automatically
- Add additional DD_API_KEY and DD_APP_KEY env vars automatically
Workflow
- ⚠️ Create your PR as draft ⚠️
- Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
- Mark it as ready for review
- Test logic is modified? -> Get a review from RFC owner. We're working on refining the
codeownersfile quickly. - Framework is modified, or non obvious usage of it -> get a review from R&P team
- Test logic is modified? -> Get a review from RFC owner. We're working on refining the
:rocket: Once your PR is reviewed, you can merge it!
Reviewer checklist
- [ ] If PR title starts with
[<language>], double-check that only<language>is impacted by the change - [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
- [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
- [ ] A docker base image is modified?
- [ ] the relevant
build-XXX-imagelabel is present
- [ ] the relevant
- [ ] A scenario is added (or removed)?
- [ ] Get a review from R&P team
@lloeki could you a look at the comment form @wconti27 in #3316 ?
Sure, I'll take a look.
Hi @lloeki , is this PR still needed ?
Hi @lloeki ,
Is this Pr still a project you plan to work on ?