system-tests icon indicating copy to clipboard operation
system-tests copied to clipboard

Pass additional env vars to docker mode container

Open lloeki opened this issue 1 year ago • 4 comments

Motivation

New AWS env vars were not passed properly in Docker mode.

Changes

  • Add AWS env vars automatically
  • Add additional DD_API_KEY and DD_APP_KEY env vars automatically

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • [ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • [ ] A docker base image is modified?
    • [ ] the relevant build-XXX-image label is present
  • [ ] A scenario is added (or removed)?

lloeki avatar Oct 24 '24 09:10 lloeki

@lloeki could you a look at the comment form @wconti27 in #3316 ?

cbeauchesne avatar Oct 25 '24 09:10 cbeauchesne

Sure, I'll take a look.

lloeki avatar Oct 29 '24 10:10 lloeki

Hi @lloeki , is this PR still needed ?

cbeauchesne avatar Feb 03 '25 14:02 cbeauchesne

Hi @lloeki ,

Is this Pr still a project you plan to work on ?

cbeauchesne avatar Oct 21 '25 22:10 cbeauchesne