system-tests icon indicating copy to clipboard operation
system-tests copied to clipboard

Enable session fingerprint and capabilities tests

Open manuel-alvarez-alvarez opened this issue 1 year ago • 1 comments

Motivation

Enables the test for session fingerprints and also RC capabilities.

Changes

Updates the java manifest and also adds the required scenario to enable the RC endpoint in the agent.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • [ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • [ ] A docker base image is modified?
    • [ ] the relevant build-XXX-image label is present
  • [ ] A scenario is added (or removed)?

manuel-alvarez-alvarez avatar Oct 02 '24 14:10 manuel-alvarez-alvarez

You have changed the scenario, I think that it worth to check that the tests are running in the rest of the languages, I think that you should remove [java] from the title before merging the PR.

uurien avatar Oct 03 '24 06:10 uurien

CI failing

Should be working fine now.

manuel-alvarez-alvarez avatar Oct 07 '24 16:10 manuel-alvarez-alvarez