system-tests icon indicating copy to clipboard operation
system-tests copied to clipboard

Add ASM Standalone testing endpoints to Ruby weblogs

Open vpellan opened this issue 1 year ago • 0 comments

Changes

  • Changed the tests logic to use request id (rid) instead of resource name
  • Added /requestdownstream and /returnheaders endpoints to Rack, Rails and Sinatra weblogs

File to review for asm-libraries and system-tests-core reviewers:

All the other changes are specific to ruby

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • [ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • [ ] A docker base image is modified?
    • [ ] the relevant build-XXX-image label is present
  • [ ] A scenario is added (or removed)?

vpellan avatar Sep 30 '24 16:09 vpellan