system-tests icon indicating copy to clipboard operation
system-tests copied to clipboard

[python]: set CMAKE_BUILD_PARALLEL_LEVEL in `install_ddtrace.sh`

Open taegyunkim opened this issue 6 months ago • 2 comments

Motivation

install_ddtrace.sh is run within a docker container and CMAKE_BUILD_PARALLEL_LEVEL didn't seem to be set.

Setting it here because setting it by default in dd-trace-py caused problems with circle ci tests https://github.com/DataDog/dd-trace-py/pull/10189.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • [ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • [ ] A docker base image is modified?
    • [ ] the relevant build-XXX-image label is present
  • [ ] A scenario is added (or removed)?

taegyunkim avatar Aug 13 '24 01:08 taegyunkim