[nodejs] add base images

[rochdev]

Motivation

Avoid redoing this on every commit.

Changes

Add base images for Node.js

Workflow

1. ⚠️ Create your PR as draft ⚠️
2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
3. Mark it as ready for review
   • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
   • Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

• [ ] Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
• [ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
• [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
• [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
• [ ] A docker base image is modified?
  • [ ] the relevant build-XXX-image label is present
• [ ] A scenario is added (or removed)?
  • [ ] Get a review from R&P team

[rochdev]

@cbeauchesne Do you know why the images are not building? I copied everything from Python and yet it doesn't look to be doing anything.

[cbeauchesne]

Right now, there is a small egg-chicken bug introduced in my last PR on pull command. Once this PR is ready, if I didn't fixed it (#2704), I'll hack it.

[rochdev]

I made the changes requested, so in theory this should be good to go, but I don't know how to test it and adding the label doesn't seem to have worked.

[cbeauchesne]

You have an error in your script : https://github.com/DataDog/system-tests/actions/runs/9912836061/job/27388583055#step:5:409

[rochdev]

@cbeauchesne I've merged the latest changes from the main branch and tried fixing the script, but I still don't understand how to make this work. It doesn't seem to be building the base images at all even though the label is on the PR, so every test fails because the base image cannot be found.

[rochdev]

Putting this as ready for review since the code is identical to Python, so my assumption is that the failures are because something needs to be done by the R&P team (which seems to also be hinted to in the doc).

[cbeauchesne]

I put back the Pr in draft mode, to save a little bit my notification stack. Put it back to normal when you need a review.

Side node, theoritically, it requires not manual step from us. But it'll be a good idea to wait for Roberto or myseilf to merge this PR, to handle any issue on gitlab process (it'll be gitlab who will build and push the images that'll be used every where)

[rochdev]

It's failing because the path to install_ddtrace is not the good one.

Now it's the good one and still failing as the base image doesn't seem to be getting built at all.

[cbeauchesne]

the base image doesn't seem to be getting built at all.

They are built : https://github.com/DataDog/system-tests/actions/runs/10099872631/job/27930016319?pr=2677#step:5:123

But it fail because it try to the get the express base image, while the job is on the nextjs weblog : https://github.com/DataDog/system-tests/actions/runs/10099872631/job/27930016319?pr=2677#step:9:131

[cbeauchesne]

Hi @rochdev ,

Do you still plan to merge this PR ?

[rochdev]

Closing as I was never able to make this work. I'll open a new PR if I ever pick up that work.