system-tests icon indicating copy to clipboard operation
system-tests copied to clipboard

Enable OTEL Span Link tests for recently implemented libraries

Open zacharycmontoya opened this issue 9 months ago • 0 comments

Motivation

We want to release OTEL Span Links this quarter so we will need to make sure they all pass the system-tests we've written.

Changes

Enables the various OTEL Span Links tests for more languages.

Test Status

  • [ ] Go
  • [X] Node
  • [X] Ruby
  • [X] PHP

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • [ ] Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • [ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • [ ] A docker base image is modified?
    • [ ] the relevant build-XXX-image label is present
  • [ ] A scenario is added (or removed)?

zacharycmontoya avatar Apr 30 '24 00:04 zacharycmontoya