system-tests
system-tests copied to clipboard
W3C Phase 3 Extract `p` Regardless of Order
Motivation
To make sure the traces are following the expected behavior when it comes to extracting the p
tag to the spans under the current conditions based on the RFC.
https://docs.google.com/document/d/1Zc7uAQTJ2G5vHEbmx8k4vMnYdQ-BnqZxewXk0ohgd3g/edit#heading=h.53cixy7xk9rp
Changes
Added two new tests to check the created tags when the trace & span Id match and the outcome in scenarios where it doesn't or the tag shouldn't be added.
Workflow
- ⚠️ Create your PR as draft ⚠️
- Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
- Mark it as ready for review
- Test logic is modified? -> Get a review from RFC owner. We're working on refining the
codeowners
file quickly. - Framework is modified, or non obvious usage of it -> get a review from R&P team
- Test logic is modified? -> Get a review from RFC owner. We're working on refining the
:rocket: Once your PR is reviewed, you can merge it!
Reviewer checklist
- [ ] Relevant label (
run-parametric-scenario
,run-profiling-scenario
...) are presents - [ ] If PR title starts with
[<language>]
, double-check that only<language>
is impacted by the change - [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
- [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
- [ ] A docker base image is modified?
- [ ] the relevant
build-XXX-image
label is present
- [ ] the relevant
- [ ] A scenario is added (or removed)?
- [ ] Get a review from R&P team